how-to: source-code: import sending-patches#73
Merged
Conversation
|
Link to docs build: https://canonical-kernel-docs--73.com.readthedocs.build/en/73/ |
gagath
force-pushed
the
gagath/sending-patches
branch
from
fafc8ee to
b8f8284
Compare
AnneCYH
reviewed
Jun 27, 2025
docs/how-to/source-code/index.md
Outdated
|
|
||
| Obtain kernel source using Git <obtain-kernel-source-git> | ||
| Enable kernel source package repositories <enable-source-repositories> | ||
| Sending patches <sending-patches> |
Collaborator
There was a problem hiding this comment.
Suggested change
| Sending patches <sending-patches> | |
| Send patches to the mailing list <send-patches> |
AnneCYH
reviewed
Jun 27, 2025
Collaborator
There was a problem hiding this comment.
Hi @gagath , thanks for this.
I will be using the same scope to review the update.
Collaborator
There was a problem hiding this comment.
Please rename the file to "send-patches.rst".
AnneCYH
reviewed
Jun 27, 2025
| @@ -0,0 +1,55 @@ | |||
| .. _sending-patches: | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| .. _sending-patches: | |
| .. _how-to-send-patches: |
AnneCYH
reviewed
Jun 27, 2025
Comment on lines
4
to
5
| Sending patches to the mailing-list | ||
| ################################### |
Collaborator
There was a problem hiding this comment.
Suggested change
| Sending patches to the mailing-list | |
| ################################### | |
| How to send patches to the mailing-list | |
| ####################################### |
AnneCYH
reviewed
Jun 27, 2025
| Sending patches to the mailing-list | ||
| ################################### | ||
|
|
||
| To send patches to the mailing-list, you should use the ``git send-email`` |
Collaborator
There was a problem hiding this comment.
Suggested change
| To send patches to the mailing-list, you should use the ``git send-email`` | |
| To send kernel patches to the mailing-list, you should use the ``git send-email`` |
To make it clearer that this is for sending kernel patches especially if users are trying to get here from search engines.
AnneCYH
reviewed
Jun 27, 2025
Comment on lines
16
to
17
| Specifying series | ||
| ================= |
Collaborator
There was a problem hiding this comment.
Suggested change
| Specifying series | |
| ================= | |
| Specify series | |
| ============== |
AnneCYH
reviewed
Jun 27, 2025
Comment on lines
19
to
21
| Since patches must be targeted at some series (unstable, noble, ...) | ||
| you need to also specify this. The ``--subject-prefix`` option can be used | ||
| in this regard: |
Collaborator
There was a problem hiding this comment.
Suggested change
| Since patches must be targeted at some series (unstable, noble, ...) | |
| you need to also specify this. The ``--subject-prefix`` option can be used | |
| in this regard: | |
| All patches must be targeted at some series (unstable, noble, ...). | |
| Specify the targeted series with the ``--subject-prefix`` option: |
It is common to explain to partners how they can send patches on our mailing-list. While this guide was previously internal, shipping it into the public documentation makes more sense as it can help anyone who wants to contribute to the Ubuntu kernel development. A separate commit in the private documentation will be created to redirect to this new page once accepted and live. Signed-off-by: Agathe Porte <agathe.porte@canonical.com>
gagath
force-pushed
the
gagath/sending-patches
branch
from
b8f8284 to
6126782
Compare
Contributor
Author
|
Thanks for the review, I believe I fixed all of the open items. |
AnneCYH
reviewed
Jun 30, 2025
Signed-off-by: AnneCYH <anne.chew@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is common to explain to partners how they can send patches on our mailing-list. While this guide was previously internal, shipping it into the public documentation makes more sense as it can help anyone who wants to contribute to the Ubuntu kernel development.
A separate commit in the private documentation will be created to redirect to this new page once accepted and live.